tests: make compression + debugging tests cross-platform - #17
Merged
gokulkrishna98 merged 1 commit intoJun 15, 2026
Merged
Conversation
- tests/compression/test_compression.py: replace the file-local
`_validate_execution` helper with the shared `validate_numerical_output`
util from `tests/utils.py`. The util goes through the standard
numerical-validation path that already works across platforms, so the
separate helper is no longer needed.
- tests/debugging/{test_debug_info,test_inspector,test_validator}.py:
add `pytest.mark.skipif(sys.platform != "darwin", ...)` to tests that
load a runtime asset via `AIModel.load`, since that path is only
supported on macOS today. The tests fail with a "no such file or
directory" error on Linux otherwise.
gokulkrishna98
requested review from
DawerG,
Lewis300,
TobyRoseman,
YifanShenSZ,
cymbalrush and
jakesabathia2
June 15, 2026 20:48
Lewis300
approved these changes
Jun 15, 2026
cymbalrush
approved these changes
Jun 15, 2026
YifanShenSZ
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
_validate_executionhelper with the sharedvalidate_numerical_outpututil fromtests/utils.py. The util goes through the standard numerical-validation path that already works across platforms, so the separate helper is no longer needed.pytest.mark.skipif(sys.platform != "darwin", ...)to tests that load a runtime asset viaAIModel.load, since that path is only supported on macOS today. The tests fail with a "no such file or directory" error on Linux otherwise.Testing:
python unit test
CI